This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Re; Maintaining, was: Re: Reduce Dwarf Debug Size

Mike Stump <mrs@apple.com> writes:

> Likewise:
> 
>    http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00167.html

This patch looks wrong to me.  I don't understand how it could be
correct in the presence of __attribute__ ((aligned (N))).  It checks
TYPE_PACKED but not TYPE_ALIGN or TYPE_USER_ALIGN.  The default hook
assumes that objects larger than pointers are not naturally aligned,
which does not make sense to me: given a type, we know the alignment,
and we should use that.

I don't know whether this is still a problem.  If it is, I hope the
IBM Haifa folks will look at the test cases.

Thanks for pointing out the patch.

:REVIEWURL http://gcc.gnu.org/ml/gcc-patches/2006-03/msg00167.html:

Ian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]