Re: Suspicious expand_complex_division() in tree-comlpex.c

[Marcin Dalecki <martin at dalecki dot de>]

Wiadomość napisana w dniu 2007-01-05, o godz08:36, przez Andrew Pinski:

> > Thus my question to whoever looked at this code close enough is:
> >
> > 1. Is the FALLTHRU really OK?
>
> yes, see above. Plus the fall through is only for non fp types.

Yes I see now... a quite complicated way to express the choice logic:

1. if -fcx-limited-range is set go straight for the quick overflowing  
version.
2. be strict in case of ISO C99.
3. handle floaing poing divisions more precisely then multiplications  
else.

> > 2. Shouldn't the logic when to decide which kind of implementation to
> > take
> > not look a bit more like in the multiplication case?
>
> It is the same in general anyways but division is the one that is
> different between flag_complex_method==0 and flag_complex_method==1.

OK. This confirms that the three state flag_complex_method could be
eliminated, and fcx_limited_range used directly instead.
(My final goal is of course something in the way of #pragma STDC  
CX_LIMITED_RANGE)...

Marcin Dalecki