This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch queue and reviewing (Was Re: Generator programs can only be built with optimization enabled?)


On Wed, 14 Jun 2006, Joe Buck wrote:

> On Wed, Jun 14, 2006 at 11:34:33AM -0700, Mike Stump wrote:
> > I'd welcome the issue be addressed by the SC.  I'd favor more timely  
> > reviews.  Maybe auto approval for a patch that sits for more than a  
> > week?  :-)
> I see your smilie, Mike, but GCC would rapidly decay into a pile of
> random bytes, unable to build itself, much less anything else, under such a
> policy.

Not necessarily.  There are other (bigger but perhaps not as complicated) 
open source projects, which work under a much more open scheme.  It 
doesn't need to be an everything-goes.  It could be something like trusted 
people can commit after some time, even without formal review.  If it 
breaks something it goes out again.  Trusted people would basically be 
long time committers.  I.e. a mix of maintainers and perhaps active 
write-after-approvals.  The special thing would be that they can write to 
the whole tree by default, if nobody cares enough to prevent that.

It's not like the patch authors are a bunch of unresponsible people
randomly hacking crap together ;-) (I know that nobody is saying that)  I 
would predict that GCC would gain quality by a much more open and 
accepting policy.

> I know it's frustrating for people when their hard work doesn't get
> reviewed for long periods of time.  But GCC is a mature compiler, it's
> stable, and while it has bugs and could be better, I'm not sure I *want*
> GCC to start changing much more rapidly than it changes today.  Bugs
> will be fixed, yes.  New features will be introduced, yes.  But will the
> quality level be maintained?  That's the whole reason we insist on patch
> review, so any process that speeds it up has to guarantee that will
> still get a decent review of all patches (other than the truly obvious
> ones).

All patches still would have to be sent to gcc-patches@.  We have version
control systems to back out whole patches at once.  For some things
reviewing can also happen after applying the patch (for most
self-contained things I would argue).  When the patch author is not sure 
about his way of tackling the problem he still is able to not check in 
without review or discussion.  Trust is the key.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]