This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: m68k PIC touchup
Peter S. Mazinger wrote:
> --- gcc-4.0.2/gcc/config/m68k/linux.h.mps 2006-01-08 23:02:06 +0100
> +++ gcc-4.0.2/gcc/config/m68k/linux.h 2006-01-08 23:03:02 +0100
> @@ -85,6 +85,11 @@
> LINUX_TARGET_OS_CPP_BUILTINS(); \
> builtin_define_std ("mc68000"); \
> builtin_define_std ("mc68020"); \
> + if (flag_pic) \
> + { \
> + builtin_define ("__PIC__"); \
> + builtin_define ("__pic__"); \
> + } \
This shouldn't be needed on HEAD because c-cppbuiltin.c
already defines them globally for all targets.
In gcc-4_0-branch and gcc-4_1-branch, __PIC__ and __pic__ are
already defined appropriately for all subtargets by the
TARGET_CPU_CPP_BUILTINS macro in m68k.h.
> @@ -98,10 +103,10 @@
> #undef CPP_SPEC
> #if TARGET_DEFAULT & MASK_68881
> #define CPP_SPEC \
> - "%{fPIC|fpic|fPIE|fpie:-D__PIC__ -D__pic__} %{!msoft-float:-D__HAVE_68881__} %{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
> + "%{!msoft-float:-D__HAVE_68881__} %{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
> #else
> #define CPP_SPEC \
> - "%{fPIC|fpic|fPIE|fpie:-D__PIC__ -D__pic__} %{m68881:-D__HAVE_68881__} %{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
> + "%{m68881:-D__HAVE_68881__} %{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}"
> #endif
Dropping these from 4.0/4.1 should be harmless because
they are clearly redundant, but it's not a regression
so I'd not bother.
--
// Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/ http://www.develer.com/