This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: gcc-4.0-20051124-4.0-20051201.diff.bz2 is TERRIBLE!!!

From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
To: "J.C." <jc-nospam at jr-pizarro dot jazztel dot es>, GCC Development <gcc at gcc dot gnu dot org>
Date: Mon, 05 Dec 2005 09:33:18 +0100
Subject: Re: gcc-4.0-20051124-4.0-20051201.diff.bz2 is TERRIBLE!!!
References: <43915455.7070800@jr-pizarro.jazztel.es>

J.C. wrote:

*** gcc-4.0-20051124/gcc/config/i386/i386.c     Mon Nov  7 18:55:03 2005
--- gcc-4.0-20051201/gcc/config/i386/i386.c     Thu Dec  1 01:53:01 2005
! #if defined(HAVE_GAS_HIDDEN) && defined(SUPPORTS_ONE_ONLY)

! #if defined(HAVE_GAS_HIDDEN) && (SUPPORTS_ONE_ONLY - 0)

Why did he remove the 'defined' and put the unreadable '0'?

Because it is possible that SUPPORTS_ONE_ONLY is defined to 0, in which case the older code was wrong.

Paolo

References:
- gcc-4.0-20051124-4.0-20051201.diff.bz2 is TERRIBLE!!!
  - From: J.C.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]