This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Enable FTZ/DAZ for SSE via fast math


On Thu, Aug 11, 2005 at 11:27:42PM +0100, Nix wrote:
> On 10 Aug 2005, H. J. Lu said:
> > +  /* SSE is the part of 64bit. Only need to check it for 32bit.  */
> 
> Grammar nit: this should probably be
> 
> +  /* All 64-bit targets have SSE; only check it explicitly for 32-bit ones.  */
> 
> or something like that.
> 
> > +		: "i" (0x00200000));
> > +  if (((eax ^ ebx) & 0x00200000) == 0)
> > +  if (edx & (1 << 25))
> 
> Am I the only person here who gets squicked by all this use of magic
> numbers?

I don't mind someone making such changes.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]