This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: mixing warning flags

From: Daniel Jacobowitz <drow at false dot org>
To: gcc at gcc dot gnu dot org
Date: Thu, 12 May 2005 16:45:30 -0400
Subject: Re: mixing warning flags
References: <200505121946.j4CJkff6004956@greed.delorie.com>

On Thu, May 12, 2005 at 03:46:41PM -0400, DJ Delorie wrote:
> 
> How to convert this code?  There is no single OPT_* that reflects when
> the first warning is emitted.
> 
> 	  if (params == 0 && (warn_format_nonliteral || warn_format_security))
> 	    warning (0, "format not a string literal and no format arguments");
> 	  else
> 	    warning (OPT_Wformat_nonliteral,
> 		     "format not a string literal, argument types not checked");

How about this?

	  if (params == 0 && (warn_format_nonliteral || warn_format_security))
	    warning (warn_format_security ? OPT_Wformat_security : OPT_Wformat_nonliteral,
		     "format not a string literal and no format arguments");
	  else
	    warning (OPT_Wformat_nonliteral,
		     "format not a string literal, argument types not checked");

The only useful difference being that you don't have to duplicate the
string.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

References:
- mixing warning flags
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]