This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] GCC 3.4.3: libobjc build failure

From: Zack Weinberg <zack at codesourcery dot com>
To: Andrew Pinski <pinskia at physics dot uc dot edu>
Cc: Denis Zaitsev <zzz at anda dot ru>,gcc at gcc dot gnu dot org,linux-gcc at vger dot kernel dot org,gcc-patches at gcc dot gnu dot org
Date: Mon, 20 Dec 2004 13:50:19 -0800
Subject: Re: [PATCH] GCC 3.4.3: libobjc build failure
References: <20041221023548.A8330@natasha.ward.six><81947436-52CF-11D9-9FB0-000A95D692F4@physics.uc.edu>

At Mon, 20 Dec 2004 16:38:36 -0500,
Andrew Pinski wrote:
> 
> 
> On Dec 20, 2004, at 4:35 PM, Denis Zaitsev wrote:
> 
> > This patch is for exactly the same issue as described in
> >
> > http://gcc.gnu.org/ml/gcc/2002-12/msg00033.html
> >
> > The fix is exactly the same, just another file is the target.  Without
> > it libobjc fails to build when --with-objc-gc is given to configure.
> 
> This patch is incorrect as noted before.  I am going to reject it
> as it was rejected before.  Again libobjc has no reason to include
> these headers.

The patch is the Wrong Thing in a formal sense.  However, it may be
the correct thing to do in the short term.  libobjc files have been
including coretypes.h and tm.h for a very long time; adding a few more
is not the end of the world, especially not on an old release branch!

zw

References:
- [PATCH] GCC 3.4.3: libobjc build failure
  - From: Denis Zaitsev
- Re: [PATCH] GCC 3.4.3: libobjc build failure
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]