This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
darwin.c identifier-smashing
- From: Mark Mitchell <mark at codesourcery dot com>
- To: geoffk at apple dot com, mrs at apple dot com
- Cc: gcc at gcc dot gnu dot org
- Date: Fri, 9 Jul 2004 15:20:33 -0700
- Subject: darwin.c identifier-smashing
- Reply-to: mark at codesourcery dot com
Geoff, Mike --
There's some quadratic behavior in darwin.c that needs fixing.
However, I'm a bit puzzled about how to do that, exactly, due to:
/* FIXME: This breaks the identifier hash table. */
IDENTIFIER_NODE_CHECK (TREE_VALUE (temp))->identifier.id.str
= (unsigned char *) name;
What I don't understand is why this isn't just:
TREE_VALUE (temp) = get_identifier (name);
Why is it important to stomp over an existing IDENTIFIER_NODE?
The ideal reply would take the form of a patch with a comment
explaining the issue. :-)
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com