Re: PATCH RFC: Remove fork from collect2

[Zack Weinberg <zack at codesourcery dot com>]

Andrew Pinski <pinskia@physics.uc.edu> writes:
> Here is the patch to add saveFP/restFP and other asm functions which
> Apple's libgcc exports (saveVEC/restVEC/saveVEC_vr11/restVEC_vr10
> [the save/restore functions for altivec] and
> save_world/rest_world/eh_rest_world_r10/rest_world_eh_r7r8
> [functions which is used for exception-handling]).  They are all
> private_extern functions (aka hidden).

Looks good in principle, but two questions:

1) Is private_extern really appropriate for routines that will go into
   libgcc_s.so?   (There is a LIB2FUNCS_STATIC_EXTRA variable to use
   if the routines should go only into libgcc.a.)

2) Are the .private_extern directive and -force_cpusubtype_ALL command
   line option accepted by all Darwin assemblers?  (Note I have no
   idea if there is more than one assembler for Darwin.)

Also, a meta-note: please use Content-Type text/plain and text/x-patch
for attached source files and patches (respectively), not
application/octet-stream.  And it is easier for someone who needs to
dig a patch out of the mailing list archives, years after the fact, if
you include new files in the patch (use 'cvs add' and 'cvs diff -N' --
you can safely do 'cvs add' for files [not directories] before a patch
is approved).

zw