This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: switch question in recog.c
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gcc mailing list <gcc at gcc dot gnu dot org>
- Date: Tue, 7 Oct 2003 14:59:09 -0400
- Subject: Re: switch question in recog.c
- References: <1065552882.2629.22.camel@p4>
On Tue, Oct 07, 2003 at 02:54:40PM -0400, Andrew MacLeod wrote:
> Is this really valid? Sure seems screwy to me.
>
>
> in the function asm_operand_ok(), the code looks like:
>
> <...>
> case 'X':
> result = 1;
>
> case 'g':
> if (general_operand (op, VOIDmode))
> result = 1;
> break;
>
> default:
> /* For all other letters, we first check for a register class,
> otherwise it is an EXTRA_CONSTRAINT. */
> if (REG_CLASS_FROM_CONSTRAINT (c, constraint) != NO_REGS)
> {
> case 'r':
> if (GET_MODE (op) == BLKmode)
> break;
> if (register_operand (op, VOIDmode))
> result = 1;
> }
> #ifdef EXTRA_CONSTRAINT_STR
> if (EXTRA_CONSTRAINT_STR (op, c, constraint))
> result = 1;
> if (EXTRA_MEMORY_CONSTRAINT (c, constraint))
> <...>
>
> Look at where the case 'r' is.. its inside the 'default:' case. Is that
> really kosher?
Yep. It acts basically as a label, they're only scoped by additional
switch statements. At least that's my reading of the standard.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer