This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] bootstrap problem on powerpc-apple-darwin6.6


In message <200308220230.h7M2Ut528748@tin.geop.uc.edu>, Andrew Pinski writes:
 >> 
 >> On Thu, 21 Aug 2003 20:01:03 -0400 (EDT), Andrew Pinski <pinskia@physics.uc
 >.edu> wrote:
 >> 
 >> > +              && TYPE_MIN_VALUE (inner_type) == TYPE_MIN_VALUE (outer_ty
 >pe)
 >> > +              && TYPE_MAX_VALUE (inner_type) == TYPE_MAX_VALUE (outer_ty
 >pe))
 >> 
 >> These are trees, which can't be reliably compared with ==.  It's probably
 >> simpler to just compare TYPE_PRECISION.
 >> 
 >
 >You are right I should have checked to make sure that they were not trees.
 >
 >Here is a newer patch which compares the TYPE_PRECISION and it adds some comm
 >entary
 >about the problem so this part will not be reverted or if we see another plac
 >e we 
 >can point them to here.
 >
 >Thanks,
 >Andrew Pinski
 >
 >ChangeLog:
 >	* tree-ssa.c (tree_ssa_useless_type_conversion): Check also the precisi
 >on of 
 >	the type to make sure they are really useless type conversions.
Looks pretty good.  I probably shouldn't have mentioned a system explicitly,
but just the characteristics of the system/problem.    But that's a nit.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]