This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GCC testsuite differences with and without gas on IRIX 6


Eric Christopher writes:

> > Hm. Is .space supposed to impose some alignment on the following code?
> 
> In the docs I have it doesn't say so... 'course this is the K&H book
> which has quite a few typos and omissions.

Neither does as.texinfo, Assembler Directives, .space size, fill.

So since nobody seems to see a reason why gas should warn about .space 0,
what about the following patch then?

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University


Mon Jul 28 22:12:55 2003  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>

	* read.c (s_space): Don't warn about .space 0.

Index: gas/read.c
===================================================================
RCS file: /cvs/src/src/gas/read.c,v
retrieving revision 1.66
diff -u -p -r1.66 read.c
--- gas/read.c	22 Jul 2003 15:27:06 -0000	1.66
+++ gas/read.c	28 Jul 2003 20:20:17 -0000
@@ -2970,9 +2970,7 @@ s_space (mult)
 	  bytes = repeat;
 	  if (repeat <= 0)
 	    {
-	      if (!flag_mri)
-		as_warn (_(".space repeat count is zero, ignored"));
-	      else if (repeat < 0)
+	      if (repeat < 0)
 		as_warn (_(".space repeat count is negative, ignored"));
 	      goto getout;
 	    }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]