This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Your inlining change also breaks bootstrap

> This change breaks the Objective-C bootstrap; libobjc does not build
> because the Objective-C front end does not define the new hook, and
> the code uses the hook unconditionally.  In general, new hooks of this
> kind should have a default, fall-back version that can be used.

Oops, I did fix this yesterday before commiting the patch and then
forgot to update the changelog and thus didn't listed the file in commit
command.  I am running bootstrap again and adding the hook.
About the default value, I am not quite sure what to do here.  In order
to esitmate size one must understand the nodes.
For objc I intended to use version from c-common.c.  Do you think it is
good idea to create now dead version in tree-inline.c that simply counts
number of tree nodes?

> Wed Jul  9 02:25:39 CEST 2003  Jan Hubicka  <>
> 	* c-common.c (c_estimate_num_insns_1): New static function.
> 	(c_estimate_num_insns): New global function.
> 	* c-common.h (DECL_NUM_STMTS): Rename to...
> 	(DECL_ESTIMATED_INSNS): ... this.
> 	(c_estimate_num_insns): Declare.
> 	* c-decl.c (duplicate_decls): Use DECL_ESTIMATED_INSNS.
> 	* c-semantics.c (add_stmt): Do not account statements.
> 	New.
> --
> Mark Mitchell
> CodeSourcery, LLC

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]