This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Warn on always-false BIT_AND_EXPRs (PR 9944)
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: John Levon <levon at movementarian dot org>
- Cc: gcc-patches at gcc dot gnu dot org, <gcc at gcc dot gnu dot org>
- Date: Tue, 4 Mar 2003 22:33:02 -0500 (EST)
- Subject: Re: [PATCH] Warn on always-false BIT_AND_EXPRs (PR 9944)
On Wed, 5 Mar 2003, John Levon wrote:
> A better version, against 3.3 branch CVS. It seems to work for me, with the
> caveat that if (!(a ? b : c) & 0x4) is not caught as the lhs operand is
> COND_EXPR.
(Nice material for an xfailed test.)
>
> Is this any good ?
You bet it is! (Wow, updated documentation *and* test-case!
Somebody approve it before he sneaks away! 1/2 :-)
Just one small thing (not really having scrutinized the actual
patches): copyright assignment?
brgds, H-P