On Tue, Aug 27, 2002 at 12:07:29AM -0400, Daniel Berlin wrote:
Assuming things on the faster-compiler-branch actually make the
compiler significantly faster, it should be a review limited to code
only, rather than design (IE don't ask the people to make massive
changes to patches because the reviewer thinks it would make it
"better").
I won't agree to this unconditionally. What if the patch
is really really gross and seen to be unmaintainable in
the long term?
That's why I said "assuming the branch has a reasonable checkin
policy", specifically to avoid this problem.