This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: GCC 3.2 suddenly fails every java test, CLASSPATH wrong


On Fri, Aug 16, 2002 at 11:11:39AM -0600, Tom Tromey wrote:
> >>>>> "H.J." == H J Lu <hjl@lucon.org> writes:
> 
> H.J.> "make install" shouldn't be required. It is a bug.
> 
> I agree.
> 
> -    # Determine the version so we can find the libgcj jar file.
> -    set text [eval exec "$GCJ_UNDER_TEST --version 2>@ stdout"]
> -    regexp -- "gcj \[^ \]+ (\[^ \]+) .*" $text ignore gcc_version
> -    verbose "jar file is libgcj-$gcc_version.jar"
> +    # Find the libgcj jar file.
> +    set libgcj_jar [eval exec "find $objdir/../ -name \"libgcj-*.jar\" 2>@ stdout"]
> +    verbose "jar file is $libgcj_jar"
> 
> I don't really like this hunk.  I'd rather we not use `find' in the
> test suite.
> 
> What is the problem here?  Why doesn't the existing code work?

http://gcc.gnu.org/ml/gcc/2002-08/msg00901.html

> 
> If it can't be made to work (I'd like to understand why first), let's
> use the Tcl glob command instead of `exec find'.
> 

I don't know much about tcl. But I have no problems with that as long
as it works.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]