This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5

From: Mark Mitchell <mark at codesourcery dot com>
To: Richard Henderson <rth at redhat dot com>, Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
Cc: Jason Merrill <jason at redhat dot com>, Alexandre Oliva <aoliva at redhat dot com>, Reichelt <reichelt at igpm dot rwth-aachen dot de>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
Date: Wed, 01 May 2002 10:18:58 -0700
Subject: Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5
References: <200204301529.RAA78706@numa6.igpm.rwth-aachen.de><wvlr8kvdiu0.fsf@prospero.cambridge.redhat.com><393450000.1020272117@gandalf.codesourcery.com><200205011905.26344@enzo.bigblue.local> <20020501100804.A3985@redhat.com>



--On Wednesday, May 01, 2002 10:08:04 AM -0700 Richard Henderson 
<rth@redhat.com> wrote:

> On Wed, May 01, 2002 at 07:05:26PM +0200, Franz Sirl wrote:
>>        for (p = &weak_decls; (t = *p) ; p = &TREE_CHAIN (t))
>> +	if (DECL_ASSEMBLER_NAME (decl) == DECL_ASSEMBLER_NAME (TREE_VALUE (t)))
>> +	  *p = TREE_CHAIN (t);
>
> This is wrong for iterating over the whole list.  You want
>
> 	for (p = &weak_decls; (t = *p) ;)
> 	  if (...)
> 	    *p = TREE_CHAIN (t);
> 	  else
> 	    p = &TREE_CHAIN (t);

Yup.  This version is OK, for branch and mainline.

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com

References:
- Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5
  - From: Jason Merrill
- Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5
  - From: Mark Mitchell
- Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5
  - From: Franz Sirl
- Re: Bootstrap error with gcc-20020429 snapshot on mips-sgi-irix6.5
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]