This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Unreviewed patch (was: another bootstrap failure onsparc-sun-solaris28 in cp/xref.o)


> Yes, and assemble_integer knows how to deal with
> UNALIGNED_DOUBLE_INT_ASM_OP being null.

However unaligned_integer_asm_op doesn't which makes
UNALIGNED_DOUBLE_INT_ASM_OP being null dangerous.
At the very least unaligned_integer_asm_op should read:

  const char *op = NULL
  switch (size)
    {
    ...
#ifdef UNALIGNED_DOUBLE_INT_ASM_OP
      op = UNALIGNED_DOUBLE_INT_ASM_OP;
      break;
#endif
    default:
      abort ();
    }
  if (! op)
    abort ();
  return op;

so that it aborts instead of returning NULL.

-- John
-------------------------------------------------------------------------
|   Feith Systems  |   Voice: 1-215-646-8000  |  Email: john@feith.com  |
|    John Wehle    |     Fax: 1-215-540-5495  |                         |
-------------------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]