This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Loop unroll fixes


On Mon, Sep 17, 2001 at 02:24:32PM -0700, Joe Buck wrote:
> So how about requiring such documentation as part of the patch?

Fine by me.

> but at least some explanation of what is going wrong, what the patch does,
> and why this is the right thing would make patch reviewers' lives easier
> and probably improve the quality of gcc.

In addition, it aids debugging future problems as well.

Suppose the patch is wrong in some way that causes it to fail for
some obscure target under some conditions.  Suppose this is not
discovered for a year.  If the patch is well documented, one can
quickly recall what the original problem was, as opposed to either
(1) spending lots of time re-examining the original bug, or
(2) guessing the that the old patch was wrong and reverting it.

Both (1) and (2) have happened many times in gcc history.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]