This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Patch commit requirements
- To: Mark Mitchell <mark at codesourcery dot com>
- Subject: Re: Patch commit requirements
- From: Jan Hubicka <jh at suse dot cz>
- Date: Sat, 23 Jun 2001 00:30:31 +0200
- Cc: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>, Geoff Keating <geoffk at redhat dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>, "jh at suse dot cz" <jh at suse dot cz>, "amylaar at redhat dot com" <amylaar at redhat dot com>, "law at cygnus dot com" <law at cygnus dot com>
- References: <Pine.LNX.4.33.0106222121540.13601-100000@kern.srcf.societies.cam.ac.uk> <617600000.993247101@localhost.localdomain>
> In general, I don't think reverting a patch for missing docs makes
> sense right away. My proposal was to allow 48 hours for defects to
> be corrected, on the mainline, and I think that's appropriate here, too.
> After that point, we could consider it.
Overall I agree with the patch reversal policy, when bootstrap is broken.
Perhaps the timming can be more grained. Patches breaking i386, ppc
or other major platform can have even shorter timeout, while
stuff like missing docs or broken pdp11 can wait longer then 48 hours.
Rationaly IMO is that it is easy to miss 48hour for example over weekend.
What I would consider important is an assistance on fixing particular problem.
In some cases it is easy to fix the problem, in other cases, when the patch
hits latent bug it can be dificult. In my case there has been problem on ARM
and Mips targets I didn't have access to and thus it got really difficult to
fix the problem and attempt to re-install the patch. In both cases it has
failed.
The patches to Mips solving reproducible problem got lost and the problem
on ARM got forgotten until very late 3.0 release status.
I am not sure, but if there is an platform that is considered important
enought to cause patch reversal in short period of time, there should
be some infomration about how to build simulator if available, or contact
to person who is interested in the platform to run and can give some assistance.
Mips backend seems to be missing such person for instance.
Honza
> --
> Mark Mitchell mark@codesourcery.com
> CodeSourcery, LLC http://www.codesourcery.com