This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Your patch to push_rounding
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Subject: Re: Your patch to push_rounding
- From: Jan Hubicka <jh at suse dot cz>
- Date: Wed, 21 Mar 2001 19:57:53 +0100
- Cc: jh at suse dot cz, gcc-patches at gcc dot gnu dot org, gcc at gcc dot gnu dot org
- References: <10103211857.AA01007@vlsi1.ultra.nyu.edu>
> Looks OK?
>
> Wed Mar 21 19:51:14 CET 2001 Jan Hubicka <jh@suse.cz>
>
> * recog.c (push_operand): Guard code by PUSH_ROUNDING.
>
> I'm dubious, because we didn't used to return in that case, though it might
> be OK.
I believe so - only targets who do have push instructions should use push_operand
and PUSH_ROUNDING.
For i386 it works.
I can't disable it entirely, since sh target do have push patterns, but never use
them since they are suboptimal (so PUSH_ROUNDING is not defined).
Can I check in?
Honza
>
> I'm testing this, which works fine on Alpha. Can you check it for you?