This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: configure --disable-threads



  In message <199810271529.HAA03941@monterey.sierravista.com>you write:
  > It looks to me like --disable-threads has itself been disabled.  In
  > configure, it looks like $enable_threads is supposed to take on one of
  > three states but if you use --disable-threads or --enable-threads=no,
  > later code changes the value back to '' which causes it to default
  > which, in the case of hpux, brings in dce threads.
  > 
  > The patch below isn't clean, but it shows where the issue occurs.
  > 
  > *** configure.orig	Sat Oct 17 15:37:14 1998
  > --- configure	Sat Oct 17 15:53:00 1998
  > ***************
  > *** 825,831 ****
  >   if test "${enable_threads+set}" = set; then
  >     enableval="$enable_threads"
  >     if test x$enable_threads = xno; then
  > ! 	enable_threads=''
  >   fi
  >   else
  >     enable_threads=''
  > --- 825,831 ----
  >   if test "${enable_threads+set}" = set; then
  >     enableval="$enable_threads"
  >     if test x$enable_threads = xno; then
  > ! 	enable_threads='no'
  >   fi
  >   else
  >     enable_threads=''
I don't see how that can be happening.  Look at the case statement immediately
below the code in question.


enable_threads_flag=$enable_threads
# Check if a valid thread package
case x${enable_threads_flag} in
        x | xno)
                # No threads
                target_thread_file='single'
                ;;
        xyes)
                # default
                target_thread_file=''
                ;;
        xdecosf1 | xirix | xmach | xos2 | xposix | xpthreads | xsingle | \
        xsolaris | xwin32 | xdce | xvxworks)
                target_thread_file=$enable_threads_flag
                ;;
        *)
                echo "$enable_threads is an unknown thread package" 1>&2
                exit 1
                ;;
esac


It seems to me that without your patch x${enable_threads_flag} will expand
to "x", which should match the No threads clause.  If that's not working
correctly, you need to explain why.

Also, do not send patches to configure, it is a generated file from 
configure.in and other files.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]