This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: gcc/config/dsp16xx/dsp16xx.h contains inconsistant OPTIMIZATION_OPTIONS
- To: Carlo Wood <carlo at runaway dot xs4all dot nl>
- Subject: Re: gcc/config/dsp16xx/dsp16xx.h contains inconsistant OPTIMIZATION_OPTIONS
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Mon, 06 Jul 1998 18:19:23 -0600
- cc: egcs at cygnus dot com (egcs at cygnus dot com)
- Reply-To: law at cygnus dot com
In message <199807050055.CAA27477@jolan.ppro>you write:
> In gcc/toplev.c line 3829 till 3875, the only place where
> OPTIMIZATION_OPTIONS is "called":
Right.
> In gcc/config/dsp16xx/dsp16xx.h we have:
[ ... ]
OK. Looks like nobody ever cleaned dsp16xx up. No suprise since few
folks use the dsp16xx port.
> This macro is completely without any effect: It never sets variables that
> are not already set and it never resets variables (except flag_gnu_linker).
>
> It seems more logically to me to change it to:
>
> #define OPTIMIZATION_OPTIONS(LEVEL, SIZE) \
> do { \
> flag_gnu_linker = 0; \
> \
> if (SIZE) \
> { \
> flag_strength_reduce = 0; \
> flag_inline_functions = 0; \
> } \
> } while(0)
>
> That is, if it is really wanted to reset `flag_strength_reduce' and
> `flag_inline_functions' when `optimize_size' is set.
I believe that is correct.
> Shall I make a path for this?
It would be greatly appreciated. Thanks!
jeff