Re: Compile errors in testsuite g++

[Robert Lipe <robertl at dgii dot com>]

Carlo Wood wrote:
> Here is an overview of the "(test for excess errors)" fails I get for g++:
> 
> >egrep -v '^( |In file included)' g++.log | grep -A1 '^FAIL.*test for excess errors'
> FAIL: g++.brendan/crash30.C (test for excess errors)
> /usr/include/pthread.h:438: parse error before `*'

[ many more of the same ] 

> Anyone got an idea what could be causing this?

Yep.   I ran into the same thing.

> Hmm, I guess that I should first try downgrading dejagnu again,

Won't help.

> PS /usr/include/pthread.h:438:
> 
> extern int pthread_sigmask __P ((int __how, __const sigset_t *__newmask,
>                                  sigset_t *__oldmask));


Jason and I had this discussion some time ago.  He gave me the attached
patch.  The problem is that the testsuite sets "-ansi" and with strictly
conforming ANSI namespaces, the clibc that ships with RH5.0 and 5.1
makes sigset_t disappear.

He mentioned it to Ulrich.  As I recall, Ulrich said this was a
non-problem with current glibc (where "current" is apparently something
newer than RedHat ships) so there was little interest in installing this
patch, even though it makes life in the 'make check' lane better for
that community of developers.


$ cvs diff libstdc++/stl/stl_config.h
Index: libstdc++/stl/stl_config.h
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/libstdc++/stl/stl_config.h,v
retrieving revision 1.6
diff -u -p -r1.6 stl_config.h
--- stl_config.h        1998/06/27 23:51:33     1.6
+++ stl_config.h        1998/07/01 17:51:53
@@ -118,6 +118,10 @@
        It should be upgraded to glibc 2.0 or later. */
 #   if !defined(_NOTHREADS) && __GLIBC__ >= 2 && defined(_G_USING_THUNKS)
 #     define __STL_PTHREADS
+#     ifdef __STRICT_ANSI__
+        /* Work around a bug in the glibc pthread.h.  */
+#       define sigset_t __sigset_t
+#     endif
 #   endif
 #   ifdef __EXCEPTIONS
 #     define __STL_USE_EXCEPTIONS