This is the mail archive of the
mailing list for the GCC project.
Re: egcs-980315 powerpc-ibm-aix184.108.40.206 warning fixes ...
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: egcs-980315 powerpc-ibm-aix220.127.116.11 warning fixes ...
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Mon, 23 Mar 1998 23:43:46 -0700
- cc: egcs at cygnus dot com, wilson at cygnus dot com
- Reply-To: law at cygnus dot com
In message <199803191533.KAA22672@caip.rutgers.edu>you write:
> Here is yet another warning patch (YAWP). This one fixes 129
> warnings on powerpc-ibm-aix18.104.22.168. Is it okay to install?
> Wed Mar 18 12:08:45 1998 Kaveh R. Ghazi <firstname.lastname@example.org>
> * collect2.c (scan_prog_file): Add explicit braces to avoid
> ambiguous `else'.
> * dbxout.c (dbxout_type_fields): Add braces around empty body in
> an if-statement.
> (dbxout_type): Likewise.
> * rs6000.c (rs6000_override_options): Change type of `i', `j' and
> `ptt_size' from int to size_t.
> (rs6000_file_start): Likewise for `i'.
> (rs6000_replace_regno): Add default case in enumeration switch.
> (output_epilog): Remove unused variable `i'.
> (rs6000_longcall_ref): Remove unused variables `len', `p', `reg1'
> and `reg2'.
> * rs6000.h (ADDITIONAL_REGISTER_NAMES): Add missing braces around
> (get_issue_rate, non_logical_cint_operand,
> rs6000_output_load_toc_table, function_arg_padding): Add prototype.
> * rs6000.md (udivmodsi4): Add explicit braces to avoid ambiguous
Don't you need to make sure system.h is included in rs6000.c so that
you get size_t via one of the standard system include files?
It looks fine to me, though I'd like to give Michael Meissner and/or
David Edelsohn a little longer to voice opinions on the rs6000
changes (say Thursday noon as a cutoff)?
You can go ahead and install the collect & dbxout changes now or
wait and install everything at once.