This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: egcs-980315 powerpc-ibm-aix4.1.4.0 warning fixes ...



  In message <199803191533.KAA22672@caip.rutgers.edu>you write:
  > 	Here is yet another warning patch (YAWP).  This one fixes 129
  > warnings on powerpc-ibm-aix4.1.4.0.  Is it okay to install?
  > 
  > 		Thanks,
  > 		--Kaveh
  > 
  > 
  > Wed Mar 18 12:08:45 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
  >  
  >         * collect2.c (scan_prog_file): Add explicit braces to avoid
  >         ambiguous `else'.
  >  
  >         * dbxout.c (dbxout_type_fields): Add braces around empty body in
  >         an if-statement.
  >         (dbxout_type): Likewise.
  >  
  >         * rs6000.c (rs6000_override_options): Change type of `i', `j' and
  >         `ptt_size' from int to size_t.
  >         (rs6000_file_start): Likewise for `i'.
  >         (rs6000_replace_regno): Add default case in enumeration switch.
  >         (output_epilog): Remove unused variable `i'.
  >         (rs6000_longcall_ref): Remove unused variables `len', `p', `reg1'
  >         and `reg2'.
  >  
  >         * rs6000.h (ADDITIONAL_REGISTER_NAMES): Add missing braces around
  >         initializer.
  >         (get_issue_rate, non_logical_cint_operand,
  >         rs6000_output_load_toc_table, function_arg_padding): Add prototype.
  >  
  >         * rs6000.md (udivmodsi4): Add explicit braces to avoid ambiguous
  >         `else'.
Don't you need to make sure system.h is included in rs6000.c so that
you get size_t via one of the standard system include files?

It looks fine to me, though I'd like to give Michael Meissner and/or
David Edelsohn a little longer to voice opinions on the rs6000
changes (say Thursday noon as a cutoff)?

You can go ahead and install the collect & dbxout changes now or
wait and install everything at once.



jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]