This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: egcs, system.h cutover, (second attempt)
- To: law at cygnus dot com
- Subject: Re: egcs, system.h cutover, (second attempt)
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Sat, 21 Mar 1998 07:51:26 -0500 (EST)
- Cc: egcs at cygnus dot com, wilson at cygnus dot com
> From: Jeffrey A Law <law@hurl.cygnus.com>
>
> > Wed Mar 11 12:47:24 1998 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >
> > * Makefile.in (alias.o, bitmap.o, c-aux-info.o, c-common.o,
> > c-decl.o, c-iterate.o, c-lang.o, c-lex.o, c-pragma.o, c-typeck.o,
> > caller-save.o, calls.o, collect2.o, combine.o, cse.o, dbxout.o,
> > dwarf2out.o, dwarfout.o, emit-rtl.o, except.o, explow.o, expmed.o,
> > expr.o, final.o, flow.o, function.o, getpwd.o, global.o,
> > integrate.o, jump.o, local-alloc.o, loop.o, optabs.o, pexecute.o,
> > prefix.o, print-rtl.o, print-tree.o, profile.o, real.o, recog.o,
> > reg-stack.o, regclass.o, regmove.o, reload.o, reload1.o, reorg.o,
> > rtl.o, rtlanal.o, sdbout.o, stmt.o, stor-layout.o, stupid.o,
> > tlink.o, toplev.o, tree.o, unroll.o, varasm.o, xcoffout.o): Depend
> > on system.h.
> >
> > * alias.c, bitmap.c, c-aux-info.c, c-common.c, c-decl.c,
> > c-iterate.c, c-lang.c, c-lex.c, c-pragma.c, c-typeck.c,
> > caller-save.c, calls.c, collect2.c, combine.c, cse.c, dbxout.c,
> > dwarf2out.c, dwarfout.c, emit-rtl.c, except.c, explow.c, expmed.c,
> > expr.c, final.c, flow.c, function.c, gcc.c, getpwd.c, global.c,
> > integrate.c, jump.c, local-alloc.c, loop.c, optabs.c, pexecute.c,
> > prefix.c, print-rtl.c, print-tree.c, profile.c, real.c, recog.c,
> > reg-stack.c, regclass.c, regmove.c, reload.c, reload1.c, reorg.c,
> > rtl.c, rtlanal.c, sched.c, sdbout.c, stmt.c, stor-layout.c,
> > stupid.c, tlink.c, toplev.c, tree.c, unroll.c, varasm.c,
> > xcoffout.c: Include system.h. Organize include ordering so
> > that stdarg/varargs comes before other system headers. Remove
> > spurious casts of functions assured of a prototype in system.h.
> A few notes.
>
> When adding new dependencies in Makefile.in, it's a lot easier on us
> if you add them to the end of the existing dependency list. Doing
> so creates fewer lines for us to read when reviewing the change :-)
>
> You do not need to go back and change them -- those comments are for
> future reference.
Okay.
>
> I probably would recommend smaller patch files too. The # of messages
> you have to send is higher, but each message is easier to review and
> therefore can get approved quicker :-)
Okay.
>
> Please go ahead and install this patch.
> Thanks,
> Jeff
Done.
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu Icon CMT Corp.