This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] V12 patch #4 of 14, Optimize adjusting PC-relative vector addresses

From: Segher Boessenkool <segher at kernel dot crashing dot org>
To: Michael Meissner <meissner at linux dot ibm dot com>, gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>
Date: Fri, 31 Jan 2020 17:57:43 -0600
Subject: Re: [PATCH] V12 patch #4 of 14, Optimize adjusting PC-relative vector addresses
References: <20200109225010.GA21999@ibm-toto.the-meissners.org> <20200110003431.GD30103@ibm-toto.the-meissners.org>

Hi!

On Thu, Jan 09, 2020 at 07:34:31PM -0500, Michael Meissner wrote:
> +static rtx
> +adjust_vec_address_pcrel (rtx addr, rtx element_offset, rtx base_tmp)
> +{
> +  rtx new_addr = NULL;

You don't need this variable, you can just return the value directly in
every case, and then you don't need all these "else"s either, or all
these nested blocks.  The NULL here is never used, either (you call
gcc_unreachable instead of returning it).

But, okay for trunk.  Thanks!

Segher

References:
- PowerPC -mcpu=future Version 12 patches
  - From: Michael Meissner
- [PATCH] V12 patch #4 of 14, Optimize adjusting PC-relative vector addresses
  - From: Michael Meissner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]