This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] testsuite: Unbreak compat.exp testing with alt compiler (PR testsuite/93294)
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Mike Stump <mikestump at comcast dot net>, David Malcolm <dmalcolm at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 17 Jan 2020 17:06:44 -0700
- Subject: Re: [PATCH] testsuite: Unbreak compat.exp testing with alt compiler (PR testsuite/93294)
- References: <20200116170148.GH10088@tucnak>
- Reply-to: law at redhat dot com
On Thu, 2020-01-16 at 18:01 +0100, Jakub Jelinek wrote:
> Hi!
>
> The PR87488 changes include:
> * lib/prune.exp (TEST_ALWAYS_FLAGS): Add -fdiagnostics-urls=never.
> Unfortunately, this broke all the compat.exp etc. compatibility testing with
> alternate compilers, because those compilers (likely) don't understand this
> new option and thus all alt compilations FAIL and everything that needs it
> is then UNRESOLVED.
>
> Fixed thusly, by handling it like -fdiagnostics-color=never and other
> similar options.
>
> Tested on x86_64-linux, ok for trunk?
>
> 2020-01-16 Jakub Jelinek <jakub@redhat.com>
>
> PR testsuite/93294
> * lib/c-compat.exp (compat-use-alt-compiler): Handle
> -fdiagnostics-urls=never similarly to -fdiagnostics-color=never.
> (compat_setup_dfp): Likewise.
OK
jeff
>