This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch 0/X] HWASAN v3
- From: Martin Liška <mliska at suse dot cz>
- To: Matthew Malcomson <Matthew dot Malcomson at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, "rguenther at suse dot de" <rguenther at suse dot de>, "kcc at google dot com" <kcc at google dot com>, "law at redhat dot com" <law at redhat dot com>, "dvyukov at google dot com" <dvyukov at google dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, "ian at airs dot com" <ian at airs dot com>, "dodji at redhat dot com" <dodji at redhat dot com>, "joseph at codesourcery dot com" <joseph at codesourcery dot com>, "jakub at redhat dot com" <jakub at redhat dot com>
- Date: Tue, 7 Jan 2020 16:14:42 +0100
- Subject: Re: [Patch 0/X] HWASAN v3
- References: <157295142743.27946.1142544630216676787.scripted-patch-series@arm.com> <157616229728.30610.11942820198797258041.scripted-patch-series@arm.com>
On 12/12/19 4:18 PM, Matthew Malcomson wrote:
Hello.
I've just sent few comments that are related to the v3 of the patch set.
Based on the HWASAN (limited) knowledge the patch seems reasonable to me.
I haven't looked much at the newly introduced RTL-hooks.
But these seems to me isolated to the aarch64 port.
I can also verify that the patchset works on my aarch64 linux machine and
hwasan.exp and asan.exp tests succeed.
I haven't gotten ASAN_MARK to print as HWASAN_MARK when using memory tagging,
since I'm not sure the way I found to implement this would be acceptable. The
inlined patch below works but it requires a special declaration instead of just
an ~#include~.
Knowing that, I would not bother with the printing of HWASAN_MARK.
Thanks for the series,
Martin