This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, gcc-wwdocs] Update to Fortran changes


Hi Mark,

On 11/26/19 11:46 AM, Mark Eggleston wrote:
I've check the changes with W3 validator. There are no problems related to my changes, however, it does object to the lack of character encoding in the file.

Note that some script modifies the file a bit – the final file does have a character encoding (content="text/html; charset=utf-8").

This is the first time in changing the wwwdoc, I haven't included a change log as there there doesn't appear to be any ChangeLog files.

There is only a commit log (see 'git log'); the format is still a bit in a flux as before there was only 'csv' where it applied to a single file.

[With git it is useful to have a meaningful single line (for "git log --pretty=oneline") and, if needed, an empty line and something more. As the main repository is going to move to GIT as well, this also applies there. – But you already follow this style.]

The patch is attached. OK to commit?

I wonder whether you should use a main bullet point with something like "Legacy improvements (<code>-fdec</code>)" under which you put the current list. [Or some other wording.] That makes it easier to read for users – those, who care about legacy support, can quickly look at the -fdec changes – while those interested in standard Fortran can skip it. (Except for the character-diagnostic type-info improvement, all are items seem to be for -fdec or -fdec-…)

In particular, currently, the following item does not make clear that it is about legacy support: "Variables with the <code>AUTOMATIC</code> attribute can be used in <code>EQUIVALENCE</code> statements."

I think it can remain as is with the -fdec umbrella item. But without it really requires the background knowledge that the AUTOMATIC attribute is only available with -fdec-static (or -fdec).

Cheers,

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]