This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Lewis Hyatt <lhyatt at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, joseph at codesourcery dot com
- Date: Fri, 22 Nov 2019 06:01:42 -0500
- Subject: Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)
- References: <20190926201639.GA82807@ldh.local> <alpine.DEB.2.21.1909262040450.14912@digraph.polyomino.org.uk> <20190927204144.GA86720@ldh.local> <8a30a5a30078714f399822b0513b070af59c3e88.camel@redhat.com> <20191120162708.GA45237@ldh.local> <20191120163543.GA45766@ldh.local> <1d0ea3400a755748caa6b07884d769988473a346.camel@redhat.com>
On Thu, 2019-11-21 at 21:43 -0500, David Malcolm wrote:
> This is the column number as reported in the diagnostic i.e the
> COL_NUM
> when printing e.g.
> warning: FILENAME:LINE_NUM:COL_NUM: some message
>
> It seems to me that PR 49973 and this patch cover two separate
> things:
On re-reading, I think I worded this poorly
"both PR 49973 and this patch", I meant to say (I didn't want to say
that the patch isn't for PR 49973, it's just that that PR covers two
things, if that makes sense).
> (a) bytes vs display columns in diagnostic-show-locus.c
> (b) the "COL_NUM" mentioned above.
>
> I'd prefer to omit (b) from the patch, and have the focus of the
> patch
> be (a), to tackle (b) in a separate patch.