This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Restore init_ggc_heuristics.
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Tue, 19 Nov 2019 11:03:57 +0100
- Subject: Re: [PATCH] Restore init_ggc_heuristics.
- References: <3c91e664-8624-aa73-1ebc-9fcaef1feb00@suse.cz>
On Mon, Nov 18, 2019 at 1:24 PM Martin Liška <mliska@suse.cz> wrote:
>
> Hello.
>
> After my param to option transformation, we lost automatic GGC
> detection. It's because init_ggc_heuristics is called before
> init_options_struct which memsets all the values to zero first.
>
> I've tested the patch with --enable-checking=release and I hope
> Honza can test it more?
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
I prefer to _not_ move all the functions. Moving the init_ggc_heuristics
call is OK.
Thanks,
Richard.
> Thanks,
> Martin
>
> gcc/ChangeLog:
>
> 2019-11-18 Martin Liska <mliska@suse.cz>
>
> * ggc-common.c (ggc_rlimit_bound): Move to opts.c
> (ggc_min_expand_heuristic): Likewise.
> (ggc_min_heapsize_heuristic): Likewise.
> (init_ggc_heuristics): Likewise.
> * ggc.h (init_ggc_heuristics): Remove declaration.
> * opts.c (ggc_rlimit_bound): Moved here from ggc-common.c.
> (ggc_min_expand_heuristic): Likewise.
> (ggc_min_heapsize_heuristic): Likewise.
> (init_ggc_heuristics): Likewise.
> (init_options_struct): Init GGC params.
> * toplev.c (general_init): Remove call to init_ggc_heuristics.
> ---
> gcc/ggc-common.c | 103 ---------------------------------------------
> gcc/ggc.h | 3 --
> gcc/opts.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++
> gcc/toplev.c | 4 --
> 4 files changed, 106 insertions(+), 110 deletions(-)
>
>