This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/7] Remove gcc/params.* files.


On 11/12/19 10:13 PM, Rainer Orth wrote:
Hi Martin,

gcc/ChangeLog:

2019-11-06  Martin Liska  <mliska@suse.cz>

	* Makefile.in: Remove PARAMS_H and params.list
	and params.options.

this has obviously not been tested properly: it completely broke
gcc.dg/params/params.exp:

Hello.

Sorry for the breakage, I'm going to fix the issue soon.


+ERROR: couldn't open "/var/gcc/regression/trunk/11.5-gcc/build/gcc/testsuite/gcc/../../params.options": no such file or directory
[...]
+ERROR: tcl error sourcing /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/para
ms/params.exp.
[...]

once for every instance of parallel testing.

Please fix and properly follow testing procedures in the future.  Just
looking for FAILs is not enough: e.g. comparing mail-report.log before
and after the patch would have immediately shown this.

Note that the patch set was very huge and I had to test very many targets
at the same time. So that's why a fallout happened ;)

Martin


	Rainer



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]