This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/7] Apply mechanical replacement (generated patch).

On Tue, Nov 12, 2019 at 10:19 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 11/11/19 3:36 PM, Richard Biener wrote:
> > I think I've noticed at least one long line (please double-check):
> >
> > -             if (tree_to_uhwi (t) < (unsigned HOST_WIDE_INT)
> > INTEGER_SHARE_LIMIT)
> > +             if (tree_to_uhwi (t) < (unsigned HOST_WIDE_INT)
> > param_integer_share_limit)
>
> You are right, they were quite some GNU coding style violations.
>
> I'm sending updated version of the patch where I fixed that.

OK.

Thanks,
Richard.

> Martin
>
> >
> > as a followup I notice that the targets *_default_params () functions should
> > be merged into the default-options structs they have (did you check the
> > defaults are still applied and user-overridable?)
>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]