Re: [PATCH 1/2] [ARM,testsuite] Skip tests incompatible with -mpure-code

[Christophe Lyon <christophe dot lyon at linaro dot org>]

On Mon, 4 Nov 2019 at 17:54, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote:
>
> Hi Christophe,
>
> On 10/18/19 2:18 PM, Christophe Lyon wrote:
> > Hi,
> >
> > All these tests fail when using -mpure-code:
> > * some force A or R profile
> > * some use Neon
> > * some use -fpic/-fPIC
> > all of which are not supported by this option.
> >
> > OK?
>
>
> Hmm... I'm tempted to ask if it would be simpler to add a check for
> -mpure-code in the effective target checks for the above features but a
> lot of those tests don't use effective target checks consistently anyway...
>
> So this is ok, though I'm not a big fan of adding so many dg-skip-if
> directives.
>
I'm not a big fan either, that's why I asked
https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01281.html
but finally decided it was easier for me to go with the dg-skip-if approach.

I supposed that all the existing dg-skip-if related to float-abi are used
by the Arm team when running various types of validations?

Committed as r277828.

Thanks

Christophe

> Thanks,
>
> Kyrill
>
>
> >
> > Thanks,
> >
> > Christophe