This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][AMD GCN][OpenMP] Add gcc/config/gcn/t-omp-device for OpenMP declare variant kind/arch/isa
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andrew Stubbs <ams at codesourcery dot com>
- Cc: Tobias Burnus <tobias at codesourcery dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 4 Nov 2019 17:35:32 +0100
- Subject: Re: [Patch][AMD GCN][OpenMP] Add gcc/config/gcn/t-omp-device for OpenMP declare variant kind/arch/isa
- References: <3f7dd4bb-756a-0312-265a-221c2e7c42bb@codesourcery.com> <20191104153709.GK4650@tucnak> <ba3de61d-93dd-7091-28b3-e371769d9ed7@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Nov 04, 2019 at 04:33:27PM +0000, Andrew Stubbs wrote:
> On 04/11/2019 15:37, Jakub Jelinek wrote:
> > My preference would be that arch on amdgcn is something like amdgcn or gcn.
> > I hope the general distinction between arch and isa will be something that
> > will be discussed next Tuesday on the language committee, so hopefully we'll
> > know more afterwards and can tweak afterwards depending on the outcome.
> >
> > Ok with that change.
>
> I'm fine with this, too. The OpenMP support should be posted Real Soon Now.
>
> We've not been terribly consistent with "gcn" vs. "amdgcn", which is
> unfortunate, but we are where we are. Most of the API enums have "GCN", so
> let's use that, for now.
With the way it is defined in the OpenMP spec, there can be actually aliases, so
having both gcn and amdgcn as supported arch is fine too.
Jakub