Re: [Patch][Demangler] Fix for complex values

[Miguel Saldivar <saldivarcher at gmail dot com>]

There seems to be a small issue with the commit, somehow "float _Complex"
turned into "Complex"
within "demangle-expected", so the test now fails. Attached will be a fix
for it. Thank you for committing
the fix though.

Miguel

>From 7eb6afb42ff1ce1c22f0fce167c3fb593d316abb Mon Sep 17 00:00:00 2001
From: Miguel Saldivar <saldivarcher@gmail.com>
Date: Tue, 29 Oct 2019 09:17:00 -0700
Subject: [PATCH] [Patch] Fix small issue with "demangle-expected"

gcc/libiberty/
* testsuite/demangle-expected: Fix test.
---
 libiberty/ChangeLog                   | 4 ++++
 libiberty/testsuite/demangle-expected | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index bba2be8b81b..f84dc18231c 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,7 @@
+2019-10-29  Miguel Saldivar  <saldivarcher@gmail.com>
+
+       * testsuite/demangle-expected: Fix test.
+
 2019-10-28  Miguel Saldivar  <saldivarcher@gmail.com>

        * cp-demangle.c (d_print_mod): Add a space before printing `complex`
diff --git a/libiberty/testsuite/demangle-expected
b/libiberty/testsuite/demangle-expected
index 61681484d0e..bdeb69ae487 100644
--- a/libiberty/testsuite/demangle-expected
+++ b/libiberty/testsuite/demangle-expected
@@ -1278,7 +1278,7 @@ int& int_if_addable<Y>(A<sizeof
((*((Y*)(0)))+(*((Y*)(0))))>*)
 #
 --format=gnu-v3
 _Z3bazIiEvP1AIXszcl3foocvT__ELCf00000000_00000000EEEE
-void baz<int>(A<sizeof (foo((int)(), (float Complex)00000000_00000000))>*)
+void baz<int>(A<sizeof (foo((int)(), (float _Complex)00000000_00000000))>*)
 #
 --format=gnu-v3
 _Z3fooI1FEN1XIXszdtcl1PclcvT__EEE5arrayEE4TypeEv
--
2.23.0

On Mon, Oct 28, 2019 at 12:15 PM Jeff Law <law@redhat.com> wrote:

> On 10/19/19 10:35 PM, Ian Lance Taylor wrote:
> > On Sat, Oct 19, 2019 at 9:11 PM Miguel Saldivar <saldivarcher@gmail.com>
> wrote:
> >>
> >> Updated patch that uses `_Complex` and `_Imaginary`
> >>
> >> Thanks,
> >> Miguel Saldivar
> >>
> >> From 742b37c88bea0118046ac359cabe5f250d69ee30 Mon Sep 17 00:00:00 2001
> >> From: Miguel Saldivar <saldivarcher@gmail.com>
> >> Date: Sat, 19 Oct 2019 21:06:07 -0700
> >> Subject: [PATCH] Fix for complex and imaginary values
> >>
> >> gcc/libiberty/
> >> * cp-demangle.c (d_print_mod): Print " _Complex" and " _Imaginary",
> >> as opposed to "complex " and "imaginary "
> >>
> >> gcc/libiberty/
> >> * testsuite/demangle-expected: Adjust test.
> >
> > This is OK.
> >
> > Thanks.
> I've installed this on the trunk.
> jeff
>
>