This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch,avr] Fix avr build broken by r276985.


On Thu, 17 Oct 2019, Georg-Johann Lay wrote:

> Am 10/17/19 um 1:22 PM schrieb Eric Botcazou:
> >> r276985 broke avr because it removed PARAM_ALLOW_STORE_DATA_RACES from
> >> --params.  The patch fixes that by using flag_store_data_races = 1 instead.
> > 
> > Note that you'll unconditionally override the user, unlike the original
> > code.
> 
> You're right.  What about this one?

LGTM.

> Johann
> 
> 
> 	Fix breakage introduced by r276985.
> 	* config/avr/avr.c (avr_option_override): Remove set of
> 	PARAM_ALLOW_STORE_DATA_RACES.
> 	* common/config/avr/avr-common.c (avr_option_optimization_table)
> 	[OPT_LEVELS_ALL]: Turn on -fallow-store-data-races.
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]