This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2][MSP430] Optimize zero_extend insns and PSImode pointer manipulation


Hi Segher!

On Wed, 9 Oct 2019 03:47:32 -0500
Segher Boessenkool <segher@kernel.crashing.org> wrote:

> Hi Jozef,
> 
> On Tue, Oct 08, 2019 at 11:39:57AM +0100, Jozef Lawrynowicz wrote:
> > +;; ------------------------
> > +;; ZERO EXTEND INSTRUCTIONS
> > +;; Byte-writes to registers clear bits 19:8
> > +;;   * Byte-writes to memory do not affect bits 15:8
> > +;; Word-writes to registers clear bits 19:16
> > +;; PSImode writes to memory clear bits 16:4 of the second memory word  
> 
> Should that be 15:4 instead?

Whoops, nice spot. I'll fix that before applying (if it gets approved) rather
than re-submitting.
> 
> > +; FIXME many of these should be unnnecessary once combine deals with
> > +; (sign_extend (zero_extend)) or (sign_extend (subreg)) BZ 91865.  
> 
> I have looked at it some time ago, and it is quite hard :-/  It's not
> forgotten though!

Ok, thanks for the update!
Jozef
> 
> 
> Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]