This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause

From: Kwok Cheung Yeung <kcy at codesourcery dot com>
To: Thomas Schwinge <thomas at codesourcery dot com>, Tobias Burnus <tobias at codesourcery dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, <gcc-patches at gcc dot gnu dot org>, <fortran at gcc dot gnu dot org>
Date: Mon, 7 Oct 2019 14:16:44 +0100
Subject: Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause
Ironport-sdr: xoODyWgqFb5gPg9B7Of5pCez1LSeFJoNDguDvCLXA0X3b0mnW+pJvuGSKsz3HXRG82J4uSIAao cGNt5pFuEyul2hinIeIlFDD5MAC5GCO4YseN8lDfrnBPUr+65wQwz9dX4F/ucj5cou+Fp5mBqz v1U1qbzQGe96HhvyWBcHl0C4JE97odSFPqlj1wfLRrn7+07w0DYOBmlhFs0dYwXIgvqTnQrXQs MvpHivjG1OJR6jZUVbbBM6W8wG7pN9owsoRtsRdKquRBsJHayfPSTJT8F4S+jnKgduHhmyaDVm ksY=
Ironport-sdr: 40aeDlbWyFzCVP6mBp6StoXBVwaEmV4Ojt5a+5mTkvqLihku7b2wZWjEPMTvWs/809g2fBvQj9 uImiKm93og7is+G1g7A7RoOkO4KQ12jPSt9oL5Al7WcebZOgp9FQVQBAeAx1cX5BHLb9cBlOs+ /Piz85Z4OTX6HBpL6uL7Ogfv+NFp7oa16SBT+9uJZPp6a3rNG4Hth1uQQWMBwCNOqHhi6uImY9 ioWZB1j1QeNQlFqHwRBEqhhWOlI9v9lLisu8qgRYEKgJ1f/qBA131BmLDVgP0ZaOpTxXOsc63g 5L0=
References: <6aaaeec8-9c6d-9293-5b6c-622d9fcf2664@codesourcery.com> <bd7250a4-3976-4d69-6466-f11fa7922a79@codesourcery.com> <20190712114122.GA2125@tucnak> <f4806bcc-83ef-0bfd-6679-058673642c2d@codesourcery.com> <875zl03o0s.fsf@euler.schwinge.homeip.net>

On 07/10/2019 10:25 am, Thomas Schwinge wrote:

Hi Kwok, Tobias!

On 2019-07-29T21:55:52+0100, Kwok Cheung Yeung <kcy@codesourcery.com> wrote:

  >  		if (omp_is_reference (new_var)
  > 		    && TREE_CODE (TREE_TYPE (new_var)) != POINTER_TYPE)

As is, this code in lower_omp_target will always reject optional arguments, so
it must be changed. This was introduced in commit r261025 (SVN trunk) as a fix
for PR 85879, but it also breaks support for arrays in firstprivate, which was
probably an unintended side-effect.


Do we have sufficient testsuite coverage for "arrays in firstprivate", in
all languages?

I don't know about other languages, but for Fortran, definitely not. Theonly testcase that exercises this AFAIK is optional-firstprivate.f90 inpart 5 of this patch series.


Kwok

References:
- Re: [PATCH 2/5, OpenACC] Support Fortran optional arguments in the firstprivate clause
  - From: Thomas Schwinge

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]