This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Enabling rtl checking by default (was Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove())
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Aaron Sawdey <acsawdey at linux dot ibm dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Michael Matz <matz at suse dot de>, Segher Boessenkool <segher at kernel dot crashing dot org>, Bill Schmidt <wschmidt at linux dot ibm dot com>, David Edelsohn <dje dot gcc at gmail dot com>, richard dot sandiford at arm dot com
- Date: Thu, 3 Oct 2019 12:20:55 +0200
- Subject: Re: Enabling rtl checking by default (was Re: [PATCH] Use movmem optab to attempt inline expansion of __builtin_memmove())
- References: <85494829-c454-3448-2951-0cc2a36df507@linux.ibm.com> <8351a374-cd11-32c0-ef28-6757c7d142d9@redhat.com> <de5c2e23-6435-698d-c55d-2a8a124ab372@linux.ibm.com> <20191002223548.GO15914@tucnak> <4ecdfed3-13b1-9a8d-1e21-a89f9d3d0415@linux.ibm.com> <mptmueit9tq.fsf_-_@arm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Oct 03, 2019 at 11:14:25AM +0100, Richard Sandiford wrote:
> Confusingly, it needs to be --enable-checking=yes,extra,rtl for rtl
> to be a pure addition to the default.
>
> I guess it's time for a new entry in the semi-regular series
> "should rtl checking be enabled by default for development builds?" :-)
> Is it realy so expensive that it needs to be off by default? And do
> we gain much from having it off by default when many developers just
> enable it anyway? The status quo seems like an unnecessary trap to me.
>
> "rtl" checking is an everyday checking option that regularly finds
> problems, unlike say "df" and "fold" (which very rarely find problems)
> and "gcac" (which definitely isn't an everyday option).
rtl checking can be everyday checking option (it is e.g. for me), but I'm
not sure if it needs to be forced onto all the developers, e.g. those
working on FEs or GIMPLE will only very rarely trigger some RTL checking
failure with their changes, and it is quite expensive (mainly, the insn*.c
sources when they contain RTL checking take much longer to compile).
Perhaps we should be just recommending --enable-checking=yes,extra,rtl for
those that test RTL/backend patches?
Jakub