This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives


Hi!

Nice!

On Wed, Oct 02, 2019 at 11:24:46AM +0200, Tobias Burnus wrote:
> 	gcc/fortran/
> 	* openmp.c (gfc_match_omp_clauses): Show a clause-parsing
> 	error if none was rised before.
> 	* parse.c (matcha, matcho): If error occurred after
> 	OpenMP/OpenACC directive matched, do not try other directives.
> 
> 	gcc/testsuite/
> 	* gfortran.dg/goacc/asyncwait-1.f95: Handle new error message.
> 	* gfortran.dg/goacc/asyncwait-2.f95: Likewise

s/Likewise/Likewise./g

> 	* gfortran.dg/goacc/asyncwait-3.f95: Likewise
> 	* gfortran.dg/goacc/asyncwait-4.f95: Likewise
> 	* gfortran.dg/goacc/default-2.f: Likewise
> 	* gfortran.dg/goacc/enter-exit-data.f95: Likewise
> 	* gfortran.dg/goacc/if.f95: Likewise
> 	* gfortran.dg/goacc/list.f95: Likewise
> 	* gfortran.dg/goacc/literal.f95: Likewise
> 	* gfortran.dg/goacc/loop-2-kernels-tile.f: Likewise95

95 should move before :

> 	* gfortran.dg/goacc/loop-2-parallel-tile.f95: Likewise
> 	* gfortran.dg/goacc/loop-7.f95: Likewise
> 	* gfortran.dg/goacc/parallel-kernels-cla: Likewiseuses.f95

Similarly for uses.f95

> 	* gfortran.dg/goacc/routine-6.f90: Likewise
> 	* gfortran.dg/goacc/several-directives.f95: Likewise
> 	* gfortran.dg/goacc/sie.f95: Likewise
> 	* gfortran.dg/goacc/tile-1.f90: Likewise
> 	* gfortran.dg/goacc/update-if_present-2.: Likewisef90

Similarly for f90

> 	* gfortran.dg/gomp/declare-simd-1.f90: Likewise
> 	* gfortran.dg/gomp/pr29759.f90: Likewise

Ok with the ChangeLog nits fixed.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]