This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v4 5/7] S/390: Remove code duplication in vec_* comparison expanders
- From: Andreas Krebbel <krebbel at linux dot ibm dot com>
- To: Ilya Leoshkevich <iii at linux dot ibm dot com>, gcc-patches at gcc dot gnu dot org
- Cc: richard dot guenther at gmail dot com, richard dot sandiford at arm dot com, segher at kernel dot crashing dot org, joseph at codesourcery dot com, rdapp at linux dot ibm dot com
- Date: Tue, 1 Oct 2019 15:44:02 +0200
- Subject: Re: [PATCH v4 5/7] S/390: Remove code duplication in vec_* comparison expanders
- References: <20191001132709.87257-1-iii@linux.ibm.com> <20191001132709.87257-6-iii@linux.ibm.com>
On 01.10.19 15:27, Ilya Leoshkevich wrote:
> s390.md uses a lot of near-identical expanders that perform dispatching
> to other expanders based on operand types. Since the following patch
> would require even more of these, avoid copy-pasting the code by
> generating these expanders using an iterator.
>
> gcc/ChangeLog:
>
> 2019-08-09 Ilya Leoshkevich <iii@linux.ibm.com>
>
> PR target/77918
> * config/s390/s390.c (s390_expand_vec_compare): Use
> gen_vec_cmpordered and gen_vec_cmpunordered.
> * config/s390/vector.md (vec_cmpuneq, vec_cmpltgt, vec_ordered,
> vec_unordered): Delete.
> (vec_ordered<mode>): Rename to vec_cmpordered<mode>.
> (vec_unordered<mode>): Rename to vec_cmpunordered<mode>.
> (VEC_CMP_EXPAND): New iterator for the generic dispatcher.
> (vec_cmp<code>): Generic dispatcher.
Ok. Thanks!
Andreas