This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libgomp_g.h: Include stdint.h instead of gstdint.h
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Frederik Harwath <frederik at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, kcy at codesourcery dot com
- Date: Mon, 30 Sep 2019 09:25:53 +0200
- Subject: Re: [PATCH] libgomp_g.h: Include stdint.h instead of gstdint.h
- References: <1569826980-110728-1-git-send-email-frederik@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Sep 30, 2019 at 12:03:00AM -0700, Frederik Harwath wrote:
> Hi,
> I am a new member of Mentor's Sourcery Tools Services group and this is the first patch that I am submitting here.
> I do not have write access to the svn repository yet, hence someone would have to merge this patch for me if it gets accepted.
> But I intend to apply for an account soon.
>
> The patch changes libgomp/libgomp_g.h to include stdint.h instead of the internal gstdint.h. The inclusion of gstdint.h has been
> introduced by GCC trunk r265930, presumably because this introduced uses of uintptr_t. Since gstdint.h is not part of GCC's
> installation, several libgomp test cases fail to compile when running the tests with the installed GCC.
>
> I have tested the patch with "make check" on x86_64 GNU/Linux.
That looks wrong, will make libgomp less portable.
If anything, it should be something like:
#ifndef GCC_GENERATED_STDINT_H
#include <stdint.h>
#endif
so that if gstdint.h is available and has been included by libgomp.h
already, it doesn't try to include it.
Jakub