This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)
- From: Lewis Hyatt <lhyatt at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 26 Sep 2019 16:51:29 -0400
- Subject: Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)
- References: <20190926201639.GA82807@ldh.local> <alpine.DEB.2.21.1909262040450.14912@digraph.polyomino.org.uk>
On Thu, Sep 26, 2019 at 4:47 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Thu, 26 Sep 2019, Lewis Hyatt wrote:
>
> > A couple notes:
> > - In order to avoid any portability problems with wchar_t, the
> > equivalent of wcwidth() from libc is implemented in-house.
>
> I'm uneasy about contrib/gen_wcwidth.cpp doing the generation using host
> libc's wcwidth. The effect is that libcpp/generated_cpp_wcwidth.h is
> *not* reproducible unless you know exactly what host (libc version, locale
> used when running the program, distribution patches to libc and locale
> data) was used to run the program. I think we need a generator that works
> from Unicode data in some way so we can explicitly say what version of the
> (unmodified) Unicode data was used.
>
Got it, no problem, will find something that accomplishes this.
-Lewis