This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] Use DECL_SOURCE_LOCATION more in name-lookup.c

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 25 Sep 2019 09:09:06 -0400
Subject: Re: [C++ Patch] Use DECL_SOURCE_LOCATION more in name-lookup.c
References: <be5f4bfa-e905-1800-ef9e-0c63f02986d0@oracle.com> <20190924193448.GG14737@redhat.com>

On 9/24/19 3:34 PM, Marek Polacek wrote:

On Tue, Sep 24, 2019 at 09:07:03PM +0200, Paolo Carlini wrote:

Hi,

Marek's recent fix prompted an audit of name-lookup.c and I found a few
additional straightforward places where we should use a more accurate
location. Tested x86_64-linux.

Thanks, Paolo.

///////////////////////

/cp
2019-09-24  Paolo Carlini  <paolo.carlini@oracle.com>

	* name-lookup.c (check_extern_c_conflict): Use DECL_SOURCE_LOCATION.
	(check_local_shadow): Use it in three additional places.

/testsuite
2019-09-24  Paolo Carlini  <paolo.carlini@oracle.com>

	* g++.dg/diagnostic/redeclaration-1.C: New.
	* g++.dg/lookup/extern-c-hidden.C: Test location(s) too.
	* g++.dg/lookup/extern-c-redecl.C: Likewise.
	* g++.dg/lookup/extern-c-redecl6.C: Likewise.
	* g++.old-deja/g++.other/using9.C: Likewise.


LGTM.

Marek


OK.

Jason

References:
- [C++ Patch] Use DECL_SOURCE_LOCATION more in name-lookup.c
  - From: Paolo Carlini
- Re: [C++ Patch] Use DECL_SOURCE_LOCATION more in name-lookup.c
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]