This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Come up with debug counter for store-merging.
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Martin Liška <mliska at suse dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Eric Botcazou <ebotcazou at adacore dot com>, Jakub Jelinek <jakub at redhat dot com>, Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- Date: Thu, 19 Sep 2019 16:57:37 +0200
- Subject: Re: [PATCH] Come up with debug counter for store-merging.
- References: <1cf85dcd-2cf5-f970-c3ce-0bbc7bcafcb8@suse.cz> <CAFiYyc079H74XUfSwKc54rVkd+L35uEPJa8LotY47Khxs18jOg@mail.gmail.com>
On Wed, 18 Sep 2019 11:01:59 +0200
Richard Biener <richard.guenther@gmail.com> wrote:
> On Wed, Sep 18, 2019 at 9:22 AM Martin Liška <mliska@suse.cz> wrote:
> >
> > Hi.
> >
> > After I spent quite some time with PR91758, I would like
> > to see a debug counter in store merging for the next time.
> >
> > Ready to be installed?
> OK.
> @@ -4195,7 +4196,8 @@ imm_store_chain_info::output_merged_stores ()
> bool ret = false;
> FOR_EACH_VEC_ELT (m_merged_store_groups, i, merged_store)
> {
> - if (output_merged_store (merged_store))
> + if (dbg_cnt (store_merging)
> + && output_merged_store (merged_store))
Doesn't this over-count actual merged stores? You really count the number of attempted store merges, not the actual successful stores merged. As i would expect to count the latter, i would have expected ..
> {
> unsigned int j;
> store_immediate_info *store;
dbg_cnt (store_merging) here, i.e. after the guard that determines if
the merge is benefical, no?
thanks,