This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32

Hi Iain,

>> On 18 Sep 2019, at 09:39, Pierre-Marie de Rodat <> wrote:
>> gcc/testsuite/
>> 	* gnat.dg/system_info1.adb: New testcase.<patch.diff>
> This new test fails everywhere on Darwin, which doesn’t have an implementation for
> System.Task_Info.Number_Of_Processors
> Given 
> "pragma Obsolescent (Task_Info, "use System.Multiprocessors and CPU aspect”);”
> is it worth me trying to implement the Task_Info stuff?

I'm seeing the same on Solaris (will be every non-Linux/MinGW target).
I've implemented Number_Of_Processors using
sysconf(__SC_NPROCESSORS_ONLN), which is also available on Darwin.  Will
submit the patch tomorrow once testing has finished...

> or should I just skip this test on Darwin?
> (if the latter, then I would plan to apply the patch below)
> diff --git a/gcc/testsuite/gnat.dg/system_info1.adb b/gcc/testsuite/gnat.dg/system_info1.adb
> index 493a18e907..c1523a277f 100644
> --- a/gcc/testsuite/gnat.dg/system_info1.adb
> +++ b/gcc/testsuite/gnat.dg/system_info1.adb
> @@ -1,4 +1,4 @@
> ---  { dg-do run }
> +--  { dg-do run { target { ! *-*-darwin* } } }

Given that the test cannot compile on anything but *-*-linux* and
*-*-mingw*, I'd rather restrict the test to those two (or more targets
that decide to implement the missing interface).


Rainer Orth, Center for Biotechnology, Bielefeld University

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]