This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, testsuite, arm] Fix ICE in gcc.dg/gimplefe-28.c
- From: Mike Stump <mikestump at comcast dot net>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 18 Sep 2019 11:14:43 -0700
- Subject: Re: [patch, testsuite, arm] Fix ICE in gcc.dg/gimplefe-28.c
- References: <5dcb255c-4ce1-9341-cace-7759887ae382@codesourcery.com>
On Sep 13, 2019, at 12:06 PM, Sandra Loosemore <sandra@codesourcery.com> wrote:
>
> For the default multilib on arm-none-eabi, gcc.dg/gimplefe-28 has been getting an ICE because, while the target-supports infrastructure is probing to see if it can add the command-line options to enable the sqrt insn ("-mfpu=vfp -mfloat-abi=softfp"), it is not actually adding those options when building this testcase. :-S The hook to do this is already there; it just needs a case for arm.
>
> OK to commit?
Ok.
Hum, usually the arm people are so responsive. I don't think I've seen a review of this, so when they don't, I will.
General note, I do prefer the target folk chime in on such patches instead of me, as there can be subtle target things that target folks track better than I and arm is one of those targets with so many wonder and subtle things. :-)